Skip to content

fix(rendering): resolve exhaustive PR 555 review findings - #558

Merged
Juliusolsson05 merged 1 commit into
feat/render-shapes-phase1-fingerprint-catalogfrom
fix/pr555-review-findings
Jul 18, 2026
Merged

Juliusolsson05 merged 1 commit into
feat/render-shapes-phase1-fingerprint-catalogfrom
fix/pr555-review-findings

Conversation

@Juliusolsson05

Copy link
Copy Markdown
Owner

Summary

Follow-up to #555 that resolves the complete exhaustive review artifact: 55 confirmed findings, 2 plausible findings, and the residual verification findings found while closing them.

  • makes Claude and Codex provider routing total, lifecycle-accurate, bounded, and evidence-preserving
  • hardens shared Git, command, MCP, Agent Code, code-edit, and compaction protocols
  • makes fingerprinting, catalog classification, recording generations, sidecar scanning, and disk schema validation deterministic and bounded
  • restores and directly verifies curated fixture/catalog parity
  • adds focused renderer, adapter, recorder, evidence, and regression coverage

Verification

  • npm test -- --reporter=dot: 222 files passed, 1 skipped; 1330 tests passed, 5 skipped
  • npm run typecheck
  • npm run rendering-shapes:audit: 3686 observations, no fatal unknown or misroute
  • git diff --check

Scope

This PR intentionally targets feat/render-shapes-phase1-fingerprint-catalog so it can merge into #555 before #555 lands. Dirty package submodules and vendor/codex-src were excluded from the commit.

@Juliusolsson05
Juliusolsson05 merged commit aad10e8 into feat/render-shapes-phase1-fingerprint-catalog Jul 18, 2026
1 check passed
@Juliusolsson05
Juliusolsson05 deleted the fix/pr555-review-findings branch July 18, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant